Skip to content

Avoid using defer in loop by extracting a function #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Avoid using defer in loop by extracting a function #952

wants to merge 1 commit into from

Conversation

@suzaku
Copy link

@suzaku suzaku commented Aug 11, 2020 •
edited
Loading

I've also tried to download the files concurrently.

But the variance of the network latency is too big to observe any improvement.

Base automatically changed from master to main January 28, 2021 22:32
@ErikSchierboom
Copy link
Member

ErikSchierboom commented May 2, 2024

What is the benefit of not having defer in the loop? (I don't know much Go)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@suzaku @ErikSchierboom